Skip to content

Periodic_3_mesh_3: Use kernel functor #8838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

Periodic_3_mesh_3: Use kernel functor #8838

merged 1 commit into from
Apr 16, 2025

Conversation

afabri
Copy link
Member

@afabri afabri commented Apr 10, 2025

Summary of Changes

The Visual 2017 testsuite I-c-128 with /permissive- gives a compilation error . Instead of p.x() call compute_x(p).

Release Management

  • Affected package(s): Peridoc_3_mesh_3
  • License and copyright ownership: unchanged

@afabri afabri added this to the 6.1-beta milestone Apr 10, 2025
@afabri afabri requested a review from MaelRL April 10, 2025 17:56
@afabri afabri self-assigned this Apr 10, 2025
@MaelRL MaelRL changed the title Periodic_c_mesh_3: Use kernel functor Periodic_3_mesh_3: Use kernel functor Apr 10, 2025
@sloriot
Copy link
Member

sloriot commented Apr 16, 2025

Successfully tested in CGAL-6.1-Ic-132

@sloriot sloriot merged commit 08796f1 into CGAL:master Apr 16, 2025
8 checks passed
@sloriot sloriot deleted the Periodic_mesh_3-permissive-GF branch April 16, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaelRL MaelRL Awaiting requested review from MaelRL

Assignees

@afabri afabri

Labels
Bug Pkg::Periodic_3_mesh_3 Tested
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@afabri @sloriot