Skip to content

Periodic_3_mesh_3: Use kernel functor#8838

Merged
sloriot merged 1 commit intoCGAL:masterfrom
afabri:Periodic_mesh_3-permissive-GF
Apr 16, 2025
Merged

Periodic_3_mesh_3: Use kernel functor#8838
sloriot merged 1 commit intoCGAL:masterfrom
afabri:Periodic_mesh_3-permissive-GF

Conversation

@afabri
Copy link
Copy Markdown
Member

@afabri afabri commented Apr 10, 2025

Summary of Changes

The Visual 2017 testsuite I-c-128 with /permissive- gives a compilation error . Instead of p.x() call compute_x(p).

Release Management

  • Affected package(s): Peridoc_3_mesh_3
  • License and copyright ownership: unchanged

@afabri afabri added this to the 6.1-beta milestone Apr 10, 2025
@afabri afabri requested a review from MaelRL April 10, 2025 17:56
@afabri afabri self-assigned this Apr 10, 2025
@MaelRL MaelRL changed the title Periodic_c_mesh_3: Use kernel functor Periodic_3_mesh_3: Use kernel functor Apr 10, 2025
@sloriot
Copy link
Copy Markdown
Member

sloriot commented Apr 16, 2025

Successfully tested in CGAL-6.1-Ic-132

@sloriot sloriot merged commit 08796f1 into CGAL:master Apr 16, 2025
8 checks passed
@sloriot sloriot deleted the Periodic_mesh_3-permissive-GF branch April 16, 2025 16:47
efifogel pushed a commit to efifogel/cgal that referenced this pull request Jan 14, 2026
## Summary of Changes

The Visual 2017 testsuite [
`I-c-128`](https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.1-Ic-128/Periodic_3_mesh_3/TestReport_Christo_MSVC2017-Release-64bits.gz)
with `/permissive-` gives a compilation error . Instead of `p.x()` call
`compute_x(p)`.

## Release Management

* Affected package(s): Peridoc_3_mesh_3
* License and copyright ownership: unchanged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants