Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default wind unit #375

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: default wind unit #375

merged 2 commits into from
Jun 24, 2024

Conversation

y0m1g
Copy link
Contributor

@y0m1g y0m1g commented May 13, 2024

Displayed wind unit in m/s, but NetAtmo's API specifies that the unit for the returned wind values is km/h:
Screenshot 2024-05-13 at 12 29 59

Also the schema doc specifies the default value (0) is kph:

windunit:{
  type:"number"
  example:0
  description:"0 -> kph, 1 -> mph, 2 -> ms, 3 -> beaufort, 4 -> knot"
}

The wind values displayed from this module in the MagicMirror are also consistent with what I see in NetAtmo's app from my wind gauge, my unit preference being set to km/h (so values are the same but displayed unit is different).

m/s -> km/h
@y0m1g y0m1g changed the title fix: wind unit fix: default wind unit May 13, 2024
@y0m1g y0m1g marked this pull request as ready for review May 13, 2024 16:59
Copy link
Owner

@CFenner CFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CFenner CFenner merged commit e9938f2 into CFenner:main Jun 24, 2024
7 checks passed
@y0m1g y0m1g deleted the patch-1 branch June 25, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants