Add assertions when slicing

[tpadioleau]

No description provided.

[tpadioleau]

@EmilyBourne We have an out of bound access in SplineBuilder::quadrature_coefficients

[EmilyBourne]

I had a look. The problem is to do with the handling of the derivatives. They are only required when Hermite boundary conditions are used, so the rest of the time they are initialised to a ChunkSpan of size 0. It seems that your assertion doesn't handle this case

[tpadioleau]

I had a look. The problem is to do with the handling of the derivatives. They are only required when Hermite boundary conditions are used, so the rest of the time they are initialised to a ChunkSpan of size 0. It seems that your assertion doesn't handle this case

Yes I got also confused when trying to add checks in DiscreteDomain. I have modified the assertion, it should be better now.

Also, I would like to add some preconditions in

• SomeDomain::front,
• SomeDomain::back,
• SomeDomain::take_first,
• SomeDomain::take_last,
• SomeDomain::remove_first,
• SomeDomain::remove_last,
• SomeDomain::remove.

To do so I need to rework some internals of DDC that may violate these preconditions (no worry it is kind of legitimate).

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.92%. Comparing base (9aacefb) to head (98206b3).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
include/ddc/chunk_span.hpp	0.00%	0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
- Coverage   90.03%   89.92%   -0.12%     
==========================================
  Files          55       55              
  Lines        2851     2859       +8     
  Branches      969      974       +5     
==========================================
+ Hits         2567     2571       +4     
- Misses         90       92       +2     
- Partials      194      196       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[yasahi-hpc]

Some of the modifications are not very clear to me.
If you can improve the error messages, it would be nicer.
Also comments in death-tests would be helpful.

[tpadioleau]

Some of the modifications are not very clear to me. If you can improve the error messages, it would be nicer. Also comments in death-tests would be helpful.

I can try to reformulate, we want to add assertions to help diagnose out of bounds slicing operations.