Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using local notifications and nc-notifications if not found on NETCONF Server #497

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

esmasth
Copy link
Contributor

@esmasth esmasth commented Jul 25, 2024

If NETCONF server supports RFC5277 notification capability and
libnetconf2 required notifications and nc-notifications are not present
on the NETCONF server (which it is not obligated to support), then the
libyang context needs to be initialized using client side local YANG
schema files.

This change assumes that notifications and nc-notifications models are
present in searchpath directory set via nc_client_set_schema_searchpath
or in the default YANG_MODULE_DIR set via build time configuration.

This addresses #492

@esmasth esmasth force-pushed the esmasth/issue492 branch 2 times, most recently from f27ad3f to eae0c05 Compare July 25, 2024 10:28
@esmasth esmasth marked this pull request as ready for review July 25, 2024 10:28
@esmasth esmasth force-pushed the esmasth/issue492 branch 2 times, most recently from 6d52b45 to c5e88eb Compare July 25, 2024 10:32
src/session_client.c Outdated Show resolved Hide resolved
src/session_client.c Outdated Show resolved Hide resolved
If NETCONF server supports RFC5277 notification capability and
libnetconf2 required notifications and nc-notifications are not present
on the NETCONF server (which it is not obligated to support), then the
libyang context needs to be initialized using client side local YANG
schema files.

This change assumes that notifications and nc-notifications models are
present in searchpath directory set via nc_client_set_schema_searchpath
or in the default YANG_MODULE_DIR set via build time configuration.

Signed-off-by: Siddharth Sharma <[email protected]>
@michalvasko michalvasko merged commit 01614f3 into CESNET:devel Jul 26, 2024
14 checks passed
@esmasth esmasth deleted the esmasth/issue492 branch July 26, 2024 11:17
@esmasth
Copy link
Contributor Author

esmasth commented Jul 26, 2024

Thanks @michalvasko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants