Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRL path and url configuration #490

Merged
merged 7 commits into from
Jul 4, 2024
Merged

Conversation

Roytak
Copy link
Collaborator

@Roytak Roytak commented Jul 3, 2024

CRLs are now obtainable only through their x509 extension. This PR removes the following APIs:

  • nc_client_tls_set_crl_paths
  • nc_client_tls_get_crl_paths
  • nc_client_tls_ch_set_crl_paths
  • nc_client_tls_ch_get_crl_paths

Copy link
Member

@michalvasko michalvasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the functions there but mark them deprecated and leave them empty (not doing anything). That will keep the ABI compatibility.

src/session_client_tls.c Fixed Show fixed Hide fixed
src/session_client_tls.c Fixed Show fixed Hide fixed
roman added 6 commits July 3, 2024 17:03
Removed the option to obtain CRLs from a file/url.
The following client-side APIs were deprecated:
- nc_client_tls_set_crl_paths
- nc_client_tls_get_crl_paths
- nc_client_tls_ch_set_crl_paths
- nc_client_tls_ch_get_crl_paths
These attempts were redundant, since there is only one try for each auth
method.
@michalvasko michalvasko merged commit 50e3e56 into CESNET:devel Jul 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants