Support SSH authentication for non-configured users #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jktjkt
suggested changes
May 22, 2024
michalvasko
requested changes
May 23, 2024
There was a problem hiding this comment.
Except for my comment, I would add a fairly brief section into README called Supported YANG modules or something similar mentioning what YANG modules with what features the library expects to be implemented and that there is a function that creates such a context. Mention also that this single feature can be disabled and also an explicit list of the YANG modules and their features, maybe aslo with a list of disabled features of all the modules. That way a concise summary of supported features of libnetconf2 will be included and can be updated as new features are supported.
michalvasko
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the value of the YANG feature
local-users-supportedthe SSH server decides, whether to lookup authorized users from the configuration or from the system.Resolves #486