client and server tls UPDATE add pkcs11 engine support #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since ENGINE is deprecated with OpenSSL 3, please, switch to the PROVIDER API. |
jktjkt
suggested changes
Jan 19, 2024
Comment on lines
+867
to
+868
| const char* uri = getenv("TOKEN_KEY_URI"); | ||
| const char* pin = getenv("DEFAULT_USER_PIN"); |
There was a problem hiding this comment.
Are these standard variable names, and are they documented somewhere?
| @@ -387,6 +388,9 @@ nc_client_tls_update_opts(struct nc_client_tls_opts *opts, const char *peername) | |||
| char *key; | |||
| X509_LOOKUP *lookup; | |||
| X509_VERIFY_PARAM *vpm = NULL; | |||
| EVP_PKEY *pkey = NULL; | |||
| ENGINE *pkcs11 = NULL; | |||
| const char* pin = getenv("DEFAULT_USER_PIN"); | |||
There was a problem hiding this comment.
Is this a standard variable name used by other projects, and does it conform to how the OpenSSL API is "supposed to be used"? Where is the documentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding pkcs#11 support for TLS private key storage. This was tested using Intel 'Key Management Reference Application (KMRA)' project, which uses SGX enclave to store manage keys, but could be used with other pkcs#11 targets. Moves private keys from local file to remote key management storage.