config BUGFIX fix sprintf and va undef behaviour

CESNET · Jun 8, 2023 · 94ac92e · 94ac92e
1 parent 4cc9498
commit 94ac92e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/config_new_tls.c b/src/config_new_tls.c
@@ -487,13 +487,13 @@ nc_server_config_new_tls_version(const struct ly_ctx *ctx, const char *endpt_nam
 
 API int
 nc_server_config_new_tls_ciphers(const struct ly_ctx *ctx, const char *endpt_name, struct lyd_node **config,
-        uint16_t cipher_count, ...)
+        int cipher_count, ...)
 {
     int ret = 0;
     struct lyd_node *new_tree = NULL, *old = NULL;
     va_list ap;
     char *tree_path = NULL, *cipher = NULL, *cipher_ident = NULL;
-    uint16_t i;
+    int i;
 
     NC_CHECK_ARG_RET(NULL, ctx, endpt_name, config, 1);
 

diff --git a/src/server_config.c b/src/server_config.c
@@ -2153,7 +2153,8 @@ nc_server_config_transport_params(const char *algorithm, char **alg_store, NC_OP
                 ret = 1;
                 goto cleanup;
             }
-            sprintf(*alg_store, "%s,%s", *alg_store, alg);
+            strcat(*alg_store, ",");
+            strcat(*alg_store, alg);
         }
     } else {
         /* delete */
@@ -3094,7 +3095,8 @@ nc_server_config_create_cipher_suite(struct nc_server_tls_opts *opts, const char
             ret = 1;
             goto cleanup;
         }
-        sprintf(opts->ciphers, "%s:%s", opts->ciphers, ssl_cipher);
+        strcat(opts->ciphers, ":");
+        strcat(opts->ciphers, ssl_cipher);
     }
 
 cleanup:

diff --git a/src/server_config.h b/src/server_config.h
@@ -361,7 +361,7 @@ int nc_server_config_new_tls_version(const struct ly_ctx *ctx, const char *endpt
  * @return 0 on success, non-zero otherwise.
  */
 int nc_server_config_new_tls_ciphers(const struct ly_ctx *ctx, const char *endpt_name, struct lyd_node **config,
-        uint16_t cipher_count, ...);
+        int cipher_count, ...);
 
 #endif /* NC_ENABLED_SSH_TLS */