-
Notifications
You must be signed in to change notification settings - Fork 16
vocabularies: updated resource type vocab #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6e1068 to
e7efeb5
Compare
c8aa54e to
5587f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just suggested for CSL regulation for all the circulars, but I don't think it's that important since it's about citation generation.
5587f24 to
079481a
Compare
| datacite_general: Text | ||
| datacite_type: Thesis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we recently apply this change? See here
| datacite_general: Text | |
| datacite_type: Thesis | |
| datacite_general: Dissertation | |
Below we have dissertation. Please double-check
| icon: file alternate | ||
| props: | ||
| csl: report | ||
| datacite_general: Text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we use Report instead?
See below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better for CSL to use document, see https://docs.citationstyles.org/en/stable/specification.html#file-types
and for datacite general. why do you think report would be better for the parent resource type?
| icon: file alternate | ||
| props: | ||
| csl: journal | ||
| datacite_general: Journal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a discussion to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| type: publication | ||
| marc21_type: publication | ||
| marc21_subtype: operationalcircular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think those are publications, can we use something more generic like Text?
This is applicable to all non publications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the type and marc21_type are based on the parent type, which for this is publication
| tags: | ||
| - depositable | ||
| - linkable | ||
| - id: publication-annotationcollection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be removed
| - id: publication-report | ||
| icon: file alternate | ||
| props: | ||
| csl: article |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we should have report as well
10a2a5b to
48e923d
Compare
Closes Issue: #529
