Skip to content

Conversation

@0einstein0
Copy link
Contributor

@0einstein0 0einstein0 commented Sep 2, 2025

Closes Issue: #529
Screenshot 2025-09-09 at 09 38 04

@0einstein0 0einstein0 force-pushed the rscrctyp branch 2 times, most recently from a6e1068 to e7efeb5 Compare September 2, 2025 08:36
@0einstein0 0einstein0 changed the title Rscrctyp vocabularies: updated resource type vocab Sep 2, 2025
@0einstein0 0einstein0 force-pushed the rscrctyp branch 2 times, most recently from c8aa54e to 5587f24 Compare September 8, 2025 15:32
@0einstein0 0einstein0 linked an issue Sep 22, 2025 that may be closed by this pull request
Copy link

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just suggested for CSL regulation for all the circulars, but I don't think it's that important since it's about citation generation.

Comment on lines 401 to 402
datacite_general: Text
datacite_type: Thesis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we recently apply this change? See here

Suggested change
datacite_general: Text
datacite_type: Thesis
datacite_general: Dissertation

Below we have dissertation. Please double-check

icon: file alternate
props:
csl: report
datacite_general: Text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we use Report instead?
See below

Copy link
Contributor

@kpsherva kpsherva Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better for CSL to use document, see https://docs.citationstyles.org/en/stable/specification.html#file-types
and for datacite general. why do you think report would be better for the parent resource type?

icon: file alternate
props:
csl: journal
datacite_general: Journal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a discussion to remove it

Copy link
Contributor

@kpsherva kpsherva Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +1025 to +939
type: publication
marc21_type: publication
marc21_subtype: operationalcircular
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think those are publications, can we use something more generic like Text?
This is applicable to all non publications.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the type and marc21_type are based on the parent type, which for this is publication

tags:
- depositable
- linkable
- id: publication-annotationcollection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

- id: publication-report
icon: file alternate
props:
csl: article
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we should have report as well

@0einstein0 0einstein0 force-pushed the rscrctyp branch 2 times, most recently from 10a2a5b to 48e923d Compare October 1, 2025 08:51
@kpsherva kpsherva merged commit cb56154 into CERNDocumentServer:master Oct 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resource_types: rename text types

4 participants