Skip to content

Conversation

@JakobMiesner
Copy link
Contributor

closes: #879

@JakobMiesner
Copy link
Contributor Author

tests failing because it requires method added here:
inveniosoftware/invenio-app-ils#1240

@JakobMiesner JakobMiesner marked this pull request as ready for review July 2, 2025 13:49
Copy link

@NielsMittelstaedt NielsMittelstaedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

* previously called `ambiguous` eitems are now called `duplicates`
* ambiguous eitems are ones where the provider is listed as the `source` of the eitem but not under `created_by`
* when ambiguous matches are detected, the import still happens as usual
@JakobMiesner JakobMiesner force-pushed the feature/importer-provider-source branch from ac81e37 to 5eb9fdc Compare September 15, 2025 15:43
@kpsherva
Copy link
Contributor

tests are failing, did you release invenio-ils ?

@kpsherva kpsherva merged commit bd551c3 into CERNDocumentServer:master Sep 24, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add information about other e-items of the same provider

3 participants