Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] [Bug] Enable date correction and demographic info scrubbing params #248

Open
jessicarowell opened this issue Jan 11, 2025 · 0 comments · May be fixed by #249
Open

[Internal] [Bug] Enable date correction and demographic info scrubbing params #248

jessicarowell opened this issue Jan 11, 2025 · 0 comments · May be fixed by #249
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jessicarowell
Copy link
Collaborator

These two parameters in metadata validation were not fully connected throughout the pipeline, resulting in the user being unable to change their values.

The keep_demographic_info flag allows the user to elect to have potentially identifying metadata (host sex, age, race, ethnicity) removed from the metadata if present (keep_demographic_info=false should remove any data for the samples).

The date_format_flag flag allows the user to select a date format of YYYY-MM or YYYY-MM-DD (or to keep whatever is in the metadata).

Run environment (container, cloud service, HPC, platform, etc.)

Command to replicate the error:

Any Additional Context or Information?

These need to be added to the module files, the config files, and the nextflow_schema.json.

Their old implementation has different variable names (val_date_format and keep_personal_info), and the latter flag currently throws an error if demographic data is found the metadata and keep_personal_info = false.

I will change this implementation to instead just remove that data if found (and log what it has done).

@jessicarowell jessicarowell added the bug Something isn't working label Jan 11, 2025
@jessicarowell jessicarowell added this to the v4.1.2 milestone Jan 11, 2025
@jessicarowell jessicarowell self-assigned this Jan 11, 2025
@jessicarowell jessicarowell linked a pull request Jan 14, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant