Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise workflow to omit incorrect "daily" and "epiweekly" language. #330

Open
damonbayer opened this issue Feb 7, 2025 · 3 comments · May be fixed by #388
Open

Revise workflow to omit incorrect "daily" and "epiweekly" language. #330

damonbayer opened this issue Feb 7, 2025 · 3 comments · May be fixed by #388
Assignees

Comments

@damonbayer
Copy link
Collaborator

When we were only fitting "e" models, the outputs were either "daily" or "epiweekly," Now that we fit "h" and "e" models, outputs can be mixed, and "h" models are always epiweekly, despite not being aggregated during post processing.

@damonbayer damonbayer self-assigned this Feb 7, 2025
@dylanhmorris
Copy link
Contributor

Could do this in the same PR as #342?

@damonbayer
Copy link
Collaborator Author

damonbayer commented Mar 7, 2025

As of now, we are producing up to 3 files per models:

  • daily_samples.parquet
  • epiweekly_samples.parquet
  • epiweekly_with_epiweekly_other_samples.parquet

As discussed above, these file names don't really make sense, as the daily and epiweekly labels do not apply to the entire file. This makes it difficult to tell what each of these files contain or if they are redundant.

I propose to, instead, produce a single samples.parquet file, containing all of the samples that were contained in the previous 3 files. We can add three new columns to this file: resolution, ("daily" or "epiweekly"), aggregated_numerator (TRUE or FALSE), and aggregated_denominator (TRUE or FALSE).

Most variables will have NA aggregated_denominator, as they are not computed as fractions.

Do you foresee any issues with this proposal @dylanhmorris?

@dylanhmorris
Copy link
Contributor

This sounds good to me. Thanks @damonbayer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants