Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Message Testing Result caching #17345

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix Message Testing Result caching #17345

merged 2 commits into from
Feb 14, 2025

Conversation

etanb
Copy link
Collaborator

@etanb etanb commented Feb 13, 2025

A very simple fix to our issue of needing to ALWAYS fetch fresh data from the testing/test endpoint. Since technically the reportBody may not change at all, BUT some backend settings changed via the Receiver Edit page, we need to always fetch fresh data to account for any changes.

Fixes #17289

@etanb etanb added the experience Team label to flag issues owned by the Experience Team label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@etanb etanb enabled auto-merge February 14, 2025 19:09
@github-actions GitHub Actions
Copy link
Contributor

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@etanb etanb merged commit c885dce into main Feb 14, 2025
33 checks passed
@etanb etanb deleted the experience/17289/caching-issue branch February 14, 2025 19:21
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Broken Links ⚠️

❌ https://www.cdc.gov/about/default.htm

Error: Request failed with status code 404

❌ https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403

❌ /assets/xlsm/20241204_ReportStream-Mapping-Template.xlsm

Error: Internal link: Page error

❌ https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpandersen87 jpandersen87 jpandersen87 approved these changes

@victor-chaparro victor-chaparro Awaiting requested review from victor-chaparro

Assignees
No one assigned
Labels
experience Team label to flag issues owned by the Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Caching Issue: Fresh requests not made on settings change
2 participants
@etanb @jpandersen87