Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize OML Mappings #16065

Open
JFisk42 opened this issue Oct 1, 2024 · 8 comments
Open

Finalize OML Mappings #16065

JFisk42 opened this issue Oct 1, 2024 · 8 comments
Assignees
Labels
etor platform Platform Team Spillover-Technical Constraints Unanticipated technical issues, bugs, or system problems that require additional time to resolve

Comments

@JFisk42
Copy link
Collaborator

JFisk42 commented Oct 1, 2024

User Story

As a Report Stream developer
I want to fully test all mapped fields for an OML message type,
so that our integration tests will alert for fields which have been modified.

Description/Use Case

OML FHIR -> HL7 Mappings to complete

Update OML integration test

  • All currently mapped OML segments/fields should be present in the integration test hl7 data.
  • Different possible segment combinations should be added. Ex: NTE and PRT are mapped different depending on which segment group they are in. NOTE: This does not include OBX permutations.

Update catchall integration tests
Some of our current mapping inventory "all possible field" integration tests are missing supported fields: NK1-13, OBR-9, OBR-14, OBR-15

Risks/Impacts/Considerations

The vast majority of test values can be taken from existing integration tests.

Acceptance Criteria

  • FHIR->HL7 mappings for OML are finished
  • All mapped fields/permutations are present in the OML integration test.
  • Any missing segment-specific fields are added to their respective integration tests.
@JFisk42 JFisk42 added the platform Platform Team label Oct 1, 2024
@JFisk42
Copy link
Collaborator Author

JFisk42 commented Oct 3, 2024

After stuffing as many notes and todos into this task as cropped up, another pass will need to be made to see if any of the low priority items here can be broken into other tickets.

@arnejduranovic arnejduranovic added the ready-for-refinement Ticket is a point where we can productively discuss it label Oct 7, 2024
@MichaelEsuruoso MichaelEsuruoso removed the ready-for-refinement Ticket is a point where we can productively discuss it label Oct 7, 2024
@MichaelEsuruoso
Copy link
Collaborator

@MichaelEsuruoso MichaelEsuruoso added the ready-for-refinement Ticket is a point where we can productively discuss it label Oct 7, 2024
@arnejduranovic
Copy link
Collaborator

All possible OML fields should be mapped -> All possible OML fields in supported segments should be mapped? @JFisk42

@JFisk42
Copy link
Collaborator Author

JFisk42 commented Oct 15, 2024

Good catch @arnejduranovic, looks like I made that mistake in a few places. You're correct that wherever I mention "all fields" I'm speaking only of fields in currently supported segments.

@MichaelEsuruoso MichaelEsuruoso added ready-for-refinement Ticket is a point where we can productively discuss it and removed ready-for-refinement Ticket is a point where we can productively discuss it labels Oct 15, 2024
@JFisk42
Copy link
Collaborator Author

JFisk42 commented Oct 19, 2024

This ticket is now ready to be refined.
Most of the originally proposed fields to add in this ticket were incorrectly identified. As part of the ORM mappings work I've created a list of mappings to update/add. I'll log a ticket for this on Monday.

@MichaelEsuruoso
Copy link
Collaborator

@MichaelEsuruoso MichaelEsuruoso removed the ready-for-refinement Ticket is a point where we can productively discuss it label Oct 21, 2024
@JFisk42 JFisk42 self-assigned this Oct 25, 2024
@JFisk42 JFisk42 added the Spillover-Technical Constraints Unanticipated technical issues, bugs, or system problems that require additional time to resolve label Nov 7, 2024
@JFisk42
Copy link
Collaborator Author

JFisk42 commented Nov 7, 2024

Spillover reason: Encountered unexpected difficulty in creating repeating segments that is a technical limitation of the hl7 parsing library we use. This resulted in several days of tracking down the exact cause of this issue. Also had to add some scope to this ticket to create some Java classes for OML to avoid some data loss in conversion.

@JFisk42
Copy link
Collaborator Author

JFisk42 commented Nov 21, 2024

Spillover reason: Main tipping factor this sprint was in some last minute technical changes. (These were related to OBR -> Specimen/ServiceRequest.extension mappings, see PR Comment). These changes had a cascade effect on test data and pushed the PR being opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
etor platform Platform Team Spillover-Technical Constraints Unanticipated technical issues, bugs, or system problems that require additional time to resolve
Projects
None yet
Development

No branches or pull requests

3 participants