Skip to content

Commit 2bc83f9

Browse files
authored
Merge pull request #16250 from CDCgov/ms/devsecops/tf-timeouts
add timeouts to other instances of azurerm_storage_account
2 parents a5a4b64 + 423be11 commit 2bc83f9

File tree

3 files changed

+27
-6
lines changed

3 files changed

+27
-6
lines changed

operations/app/terraform/modules/storage/candidate_slot.tf

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ resource "azurerm_storage_account" "storage_account_candidate" {
88
account_replication_type = "GRS"
99
min_tls_version = "TLS1_2"
1010
allow_nested_items_to_be_public = false
11-
enable_https_traffic_only = true
11+
https_traffic_only_enabled = true
1212
local_user_enabled = false
1313

1414
network_rules {
@@ -38,6 +38,13 @@ resource "azurerm_storage_account" "storage_account_candidate" {
3838
tags = {
3939
environment = var.environment
4040
}
41+
42+
timeouts {
43+
create = var.timeout_create
44+
read = var.timeout_read
45+
delete = var.timeout_delete
46+
update = var.timeout_update
47+
}
4148
}
4249

4350
module "storageaccount_candidate_blob_private_endpoint" {
@@ -155,7 +162,7 @@ resource "azurerm_storage_account" "storage_partner_candidate" {
155162
account_replication_type = "GRS"
156163
min_tls_version = "TLS1_2"
157164
allow_nested_items_to_be_public = false
158-
enable_https_traffic_only = true
165+
https_traffic_only_enabled = true
159166
local_user_enabled = false
160167

161168
network_rules {
@@ -191,6 +198,13 @@ resource "azurerm_storage_account" "storage_partner_candidate" {
191198
tags = {
192199
environment = var.environment
193200
}
201+
202+
timeouts {
203+
create = var.timeout_create
204+
read = var.timeout_read
205+
delete = var.timeout_delete
206+
update = var.timeout_update
207+
}
194208
}
195209

196210
# Grant the storage account Key Vault access, to access encryption keys

operations/app/terraform/modules/storage/main.tf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ resource "azurerm_storage_account" "storage_account" {
88
account_replication_type = "GRS"
99
min_tls_version = "TLS1_2"
1010
allow_nested_items_to_be_public = false
11-
enable_https_traffic_only = true
11+
https_traffic_only_enabled = true
1212
local_user_enabled = false
1313

1414
network_rules {
@@ -173,7 +173,7 @@ resource "azurerm_storage_account" "storage_public" {
173173
account_replication_type = "GRS"
174174
min_tls_version = "TLS1_2"
175175
allow_nested_items_to_be_public = false
176-
enable_https_traffic_only = true
176+
https_traffic_only_enabled = true
177177
local_user_enabled = false
178178

179179
static_website {
@@ -223,7 +223,7 @@ resource "azurerm_storage_account" "storage_partner" {
223223
account_replication_type = "GRS"
224224
min_tls_version = "TLS1_2"
225225
allow_nested_items_to_be_public = false
226-
enable_https_traffic_only = true
226+
https_traffic_only_enabled = true
227227
local_user_enabled = false
228228

229229
network_rules {

operations/app/terraform/modules/storage/trial_frontends.tf

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ resource "azurerm_storage_account" "storage_trials" {
99
account_replication_type = "LRS"
1010
min_tls_version = "TLS1_2"
1111
allow_nested_items_to_be_public = false
12-
enable_https_traffic_only = true
12+
https_traffic_only_enabled = true
1313
local_user_enabled = false
1414

1515
static_website {
@@ -28,4 +28,11 @@ resource "azurerm_storage_account" "storage_trials" {
2828
tags = {
2929
environment = var.environment
3030
}
31+
32+
timeouts {
33+
create = var.timeout_create
34+
read = var.timeout_read
35+
delete = var.timeout_delete
36+
update = var.timeout_update
37+
}
3138
}

0 commit comments

Comments
 (0)