You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
within the AbstractParameters class which update self but do not return anything. I think it would be more explicit and better practice to have these types of functions return the parameter in question. Should also be on the look out for any functions which silently change anything about self, these "unpure" functions are likely to create bugs in the future and are bad practice.
The text was updated successfully, but these errors were encountered:
this is part of a broader push to make methods more functionally pure. There are pieces of code like:
DynODE/src/dynode/abstract_parameters.py
Lines 493 to 510 in 3690865
within the
AbstractParameters
class which updateself
but do not return anything. I think it would be more explicit and better practice to have these types of functions return the parameter in question. Should also be on the look out for any functions which silently change anything aboutself
, these "unpure" functions are likely to create bugs in the future and are bad practice.The text was updated successfully, but these errors were encountered: