-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCC support for CEA-708 Decoder #1432
Conversation
Please fix the formatting issues by running clang-format and rustfmt |
…try point defined on ccx_decoder_608
… with entry point defined on ccx_decoder_608" This reverts commit 45f7e40.
Any idea why this PR isn't merged? Is there some work left? |
If I remember correctly, @voidash disappeared |
@ArchitBhonsle If you test this PR, you'll see that the SCC header is being repeated for each subtitle line |
Closing since @voidash seems to have vanished and there's merge conflicts and @IshanGrover2004 has been working on this anyway. |
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
When SCC was extracted from MOV file, the
SCC
file was empty. So in order to fix that this pull request is being made. The exact issue it fixes is #1426 .Now SCC can be extracted from the sample video provided in the issue. Also It might be worth mentioning that the SCC caption type is pop on.