Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCC support for CEA-708 Decoder #1432

Closed
wants to merge 10 commits into from
Closed

Conversation

voidash
Copy link

@voidash voidash commented Apr 15, 2022

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

When SCC was extracted from MOV file, the SCC file was empty. So in order to fix that this pull request is being made. The exact issue it fixes is #1426 .Now SCC can be extracted from the sample video provided in the issue. Also It might be worth mentioning that the SCC caption type is pop on.

@PunitLodha
Copy link
Member

Please fix the formatting issues by running clang-format and rustfmt

@ArchitBhonsle
Copy link
Contributor

Any idea why this PR isn't merged? Is there some work left?

@cfsmp3
Copy link
Contributor

cfsmp3 commented Mar 5, 2023

Any idea why this PR isn't merged? Is there some work left?

If I remember correctly, @voidash disappeared

@PunitLodha
Copy link
Member

Any idea why this PR isn't merged? Is there some work left?

@ArchitBhonsle If you test this PR, you'll see that the SCC header is being repeated for each subtitle line

@cfsmp3
Copy link
Contributor

cfsmp3 commented Mar 3, 2024

Closing since @voidash seems to have vanished and there's merge conflicts and @IshanGrover2004 has been working on this anyway.

@cfsmp3 cfsmp3 closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants