Experimental typescript support in script api #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also do you think it would make sense if we publish our generated definitions to npm registry? would it be just too risky (legally) for that? And publish as whom? |
|
As long as it's yarn it's safe to do so. It doesn't contain any code by Mojang and is only a JS representative of the existing yarn mappings. |
commandblock2
force-pushed
the
experimental-typescript-support-in-script-api
branch
from
8d6fe7a to
4142f3d
Compare
commandblock2
force-pushed
the
experimental-typescript-support-in-script-api
branch
3 times, most recently
from
784426c to
b487916
Compare
commandblock2
force-pushed
the
experimental-typescript-support-in-script-api
branch
from
b487916 to
0d2d6b6
Compare
|
Hi, when can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @1zun4, the experimental typescript support pr should be almost ready, there is another in-draft pr for LiquidBounce at CCBlueX/LiquidBounce#6115. If no further significant changes should be made, I will start refining the PR for LB and possibly the pipeline for generating the definitions.
Edit: the compiled script in dist can only be loaded if the #6115 pr is merged, or can only be tested on that branch
The doc is mostly written by claude but I have read it over and corrected some details.
I have tested the doc with claude-sonnet-3.7-thinking in cline(roo), it was able to setup a development environment with current imperfect definitions working as intended with the following prompt.
@/Experimental\ TypeScript\ Support.md Can you follow this and setup a project with typescript support, assuming the package is already downloaded and extracted at ~/jvm-types, we are already at
lb-typescript-scripts(actually another one, but just skip this). Ignore the hot reload settings but do use tsc --watch.roo_task_may-31-2025_10-04-56-pm.md