Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to PCA, heatmap, and functions that call them #88

Merged
merged 13 commits into from
Feb 7, 2025

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Feb 7, 2025

Changes

  • new function: plot_pca_3d()
  • refactor plot_pca() and create calc_pca() for more modular design.
  • new option to print diagnostic plots from main workflow functions.
  • improve plotting functions for easier use outside of workflow functions.
  • create initial draft of visualization vignette.

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • Write unit tests for any new features, bug fixes, or other code changes.
  • Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.).
  • Update NEWS.md with a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.html
  • Run devtools::check() locally and fix all notes, warnings, and errors.

@kopardev kopardev added the MOSuite RepoName label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 60.79545% with 138 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (aaafe30) to head (35ef62e).

Files with missing lines Patch % Lines
R/clean.R 25.92% 40 Missing ⚠️
R/normalize.R 4.76% 40 Missing ⚠️
R/pca.R 67.28% 35 Missing ⚠️
R/histogram.R 61.90% 16 Missing ⚠️
R/filter.R 91.07% 5 Missing ⚠️
R/batch-correction.R 97.43% 1 Missing ⚠️
R/heatmap.R 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   74.03%   68.67%   -5.37%     
==========================================
  Files          15       15              
  Lines         674      798     +124     
==========================================
+ Hits          499      548      +49     
- Misses        175      250      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelly-sovacool kelly-sovacool merged commit c7d1c5f into main Feb 7, 2025
@kelly-sovacool kelly-sovacool deleted the iss-49_3DPCA branch February 7, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MOSuite RepoName
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NIDAP template - 3DPCA
2 participants