Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirz-pixel
reviewed
Jul 16, 2022
| new_line = line.copy() # line을 복사해 new_line을 생성 | ||
| while element in new_line: # 특정 용량을 원하는 사람을 모두 뺌 | ||
| new_line.remove(element) | ||
| long_seq.append(max_seq_cap(new_line)) |
There was a problem hiding this comment.
리스트를 복사 -> 특정 용량 제거(set의 element) -> 최대 길이 계산(max_seq_cap 함수 호출)
수순으로 진행되는 건가보네요 ㅎㅎ
직관적으로 굉장히 잘 짜신거 같습니다!
추가적으로 new_line -> 특정 용량 제거(set의 element) 과정을 없애서 풀 수도 있으니 시간 되시면 한번 도전해보시는 걸 추천드립니다 ㅎㅎ
alirz-pixel
reviewed
Jul 17, 2022
| if rec_splited[0] == 'Enter': | ||
| answer.append(f"{uid_arch[rec_splited[1]]}님이 들어왔습니다.") | ||
| elif rec_splited[0] == 'Leave': | ||
| answer.append(f"{uid_arch[rec_splited[1]]}님이 나갔습니다.") |
There was a problem hiding this comment.
와.. split을 이용하여 깔끔하게 잘 푸셨네요 ㄷㄷㄷ
코드 잘 봤습니다 감사합니다!
alirz-pixel
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😀 PR을 올리기 전 준비
🤩 이번주 문제
18247 겨울왕국 티켓 예매
5883 아이폰 9S
오픈채팅방
🧑💻 어떻게 푸셨나요?
주석 참고
✍️ 질문을 적어주세요.
x
📖 참고 사항
5883 아이폰 9S
.copy()오픈채팅방
딕셔너리이름[키] = 값.split(): 값 반환함