Skip to content

Update #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Update #2

wants to merge 46 commits into from

Conversation

viktorklochkov
Copy link
Contributor

No description provided.

@conformist89
OK, at least I can write one pt-rap hist
c84547a
@conformist89
Can write few hists to out file, need to test tomorrow
303acfb
@conformist89
Can plot variables distributions for signal and background, train and…
6f06aaa 
… test
@conformist89
Plotted roc curve as root object
cef708d
@conformist89
Set graph titles
6e02ce3
@conformist89
Corrected train roc-curve's title
f4d3293
@conformist89
Correlation matrix using hipe4ml (but need to check carefully order)
b4f1162
@conformist89
Changed label's font size
aae6b0c
@conformist89
Set lablel title for output file
6a45ae5
@conformist89
Hipe4ML based bayesian optimization, train, test and model saving
896f853
@conformist89
Applied train and test predictions, got distributions and estimated m…
9a13d68 
…odel
@conformist89
Model is private variable
8cdda43
@conformist89
Save model as treelite library
ea16a12
@conformist89
Added getter to return a model
9cc8952
@conformist89
Deleted a comment
c854ccb
@conformist89
Distributions to root file
424fa9f
@conformist89
Deleted files with an old version of XGBoost code
41f74f8
@conformist89
Quality insurance added
d30b1ea
@conformist89
Added names of roc plots
be89cc7
@conformist89
Reading information from config files
1695282
@conformist89
Changed config reader module's name
4ac5999
@conformist89
Put files to installation folder
48e7123
@conformist89
Setip tools added
c5770cf
@conformist89
MIT licwnse added
1905959
@conformist89
Added files
c650800
@conformist89
Deleted old folder
6e74feb
@conformist89
Deleted old file
bd9fab2
@conformist89
Added requirements
140630d
@conformist89
Added hipe4ml to requirements
dcde05f
@conformist89
New module for saving hists as ROOT objects
dd326cb
@conformist89
Chabged argument of transform_df_to_log. Doesn't read config file to …
debe349 
…retrieve variables that require log scale(and ones that doesn't require, user specifies these variables
@conformist89
Deleted part with saving hists as ROOT objects(moved to separate hist…
399394f 
…s_root module
@conformist89
Added treelite(to convert predictions to C++ libraty) to dependencies
33dde1f
@conformist89
Matplotlib was deleted from requirements
bd1481b
@conformist89
Created one method to compute threshold and apply it to dataset
6cd450f
@conformist89
Corrected non-log variables return
eae53dd
@conformist89
Changed font sizes
dac89de
@conformist89
corrected signal and background diff
e7bbc38
@conformist89
hist_variables requires dataframe and labels and computes signal and …
02478e1 
…background difference inside the function
@conformist89
Changed the way of log transformation
0d5cdd6
@conformist89
Only one dataframe is required
af8cf1e
@conformist89
Added comments to ApplyXGB members
7783a23
@conformist89
One can adjust theshold manually or use optized AMS
cfef579
shahidzk1
shahidzk1 approved these changes Feb 21, 2022
View reviewed changes
Copy link

@shahidzk1 shahidzk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, "get predictions" should just give predictions. The user should then decide later on whether to use AMS cut on these predictions or not.

@conformist89
Copy link
Member

conformist89 commented Feb 23, 2022 •
edited
Loading

In my opinion, "get predictions" should just give predictions. The user should then decide later on whether to use AMS cut on these predictions or not.

@shahidzk1 I've taken to account your comment and corrected get predictions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@shahidzk1 shahidzk1 shahidzk1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@conformist89 conformist89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viktorklochkov @conformist89 @shahidzk1