Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding functionality to the complexity command #4

Merged
merged 34 commits into from
Sep 26, 2024

Conversation

gymreklab
Copy link
Contributor

Added functionality to the complexity command, including the ability to compute complexity on regions of a GBZ file, or an entire GFA file.

A notable TODO is to add gbz-base to our testing framework (we need the query and gbz2db utilities. Functions using those were tested locally but not in the test environment. After adding those to our test framework I will also need to add command line tests.

@gymreklab gymreklab marked this pull request as ready for review September 21, 2024 22:25
Copy link
Member

@aryarm aryarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a few small comments. As requested, I didn't leave a thorough review - just a quick check of standards

panct/__main__.py Outdated Show resolved Hide resolved
tests/test_graph_utils.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
panct/__main__.py Outdated Show resolved Hide resolved
panct/complexity.py Outdated Show resolved Hide resolved
@gymreklab gymreklab merged commit 4aa3a0b into main Sep 26, 2024
11 checks passed
@gymreklab gymreklab deleted the mgymrek-complexity branch September 26, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants