Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfy Clippy #25

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Conversation

dwmunster
Copy link
Contributor

Overview

Makes some tweaks to satisfy Clippy.

Details

  • Add implementations for Default for structs with a ::new() with no params.
  • Allow empty_docs. These seem to be generated by derive(Tsify)/wasm_bindgen. In particular, it generates the following:
        #[automatically_derived]
        ///
        #[repr(transparent)]
        pub struct JsType {
            obj: wasm_bindgen::JsValue,
        }
  • Adds tests for decompose::find_rings to support refactoring.
  • Use references rather than index + .get() to avoid unwrapping options in find_rings.

@dwmunster
Copy link
Contributor Author

Begone red 'X'es

@TobiasJacob TobiasJacob merged commit 2c0f625 into CADmium-Co:main Jun 3, 2024
4 checks passed
@dwmunster dwmunster deleted the bugfix/satisfy-clippy branch June 4, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants