Handle Ambiguity in RotatedRectangleDemo Positions #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since the
RotatedRectangleDemo
is underspecified and used across the tests for several solvers, this PR adds a method that will check for the four possible outcomes and test their positions to the desired tolerance.Details
The
RotatedRectangleDemo
has 7 constraints (for the rectangle):This leaves two choices for the line segment AB: above the x-axis or below the x-axis. Each of those options has two sub-options corresponding to the two orthogonal directions to the line segment AB. E.g., if AB is above the x-axis, point C can be up-and-left or down-and-right of point B.
This leaves four cases to test for, which this PR adds.
Alternatives
We could consider adding additional constraints to fully specify the rectangle. However, I think have an underconstrained example is valuable, as it helped catch an erroneous assumption of mine while working on the
GaussNewtonSolver
.