WIP: Intersections #11
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omnisci3nce
commented
May 27, 2024
src/intersections/mod.rs
Outdated
Comment on lines
71
to
81
| #[inline] | ||
| fn within_range(x: f64, a: f64, b: f64, epsilon: f64) -> bool { | ||
| if a == b && b == x { | ||
| return true; | ||
| } | ||
| if a < b { | ||
| x >= a - epsilon && x <= b + epsilon | ||
| } else { | ||
| x >= b - epsilon && x <= a + epsilon | ||
| } | ||
| } |
There was a problem hiding this comment.
I copied this from the Cadmium repository except removed the retvat and just return inline.
…oint and point intersect line duplicated
(not implemented yet)
|
Great that you start working on this. Can you move each collision function into its own file? |
|
Yeah, of course. Can do.
…On Mon, 27 May 2024, 5:40 pm Tobias Jacob, ***@***.***> wrote:
Great that you start working on this. Can you move each collision function
into its own file?
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFWZ3TM2QVUAO3AKG7YQILZELPP5AVCNFSM6AAAAABIKLMULOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSHA2DGMZZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just opening a draft PR in case anyone has feedback or improvements.