Face selection #99
Closed
Face selection #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
…fset, etc.) Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
… generate an HTML report Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
|
Merging to dev from #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the scaffold to be able to easily add and test different approaches to the face selection problem described in #98
I created a benchmark that takes all the available solvers, uses them in different test cases and produces an HTML report with SVGs showing the generated face geometry and what is selected before and after mutating the sketch.
A report looks like this:
NOTE: Something's wrong with
merge_facesand it crashes (segment not found in active-vec-set: 2), that's why the bottom right image doesn't exist. Also for some reason I can't get SVG to actually fill the path to show which face is selected