Former glory #97
Closed
Former glory #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzervas before I merge this could you run |
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
…fset, etc.) Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
Signed-off-by: Dimitris Zervas <[email protected]>
|
Merging to dev from #101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm mostly try to match the features already implemented in main with the new design, ISOTope, etc.
Many test fixes, renaming of
solidtofeature, as solids are considered computation result and not "primitive" types. For example an extrusion produces solids (maybe more than 1) but they might changeIn a similar manner now each
ISketchalso holdsCompounds. Compounds describe a fixed set of primitives that form a set. For example a rectangle is a compound that includes 4 points and 4 lines. The 2 diagonal points are given as input and the rest (2 points and 4 lines) are created in the sketch.Compounds are able to track what's theirs so upon deletion of a compound its created primitives get deleted as well
What's left is anything related to face identification (both sketch and solid) - so create sketch on solid face, extrude (ok extrude is implemented but I imagine it's very flaky), etc.