web: reimplement new line tool state with stack instead of nested ifs #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattFerraro
reviewed
Jun 3, 2024
| switch (stack.length) { | ||
| case 0: // nothing to do, the stack is empty | ||
| break | ||
| case 1: // can't create a line with only one point! |
There was a problem hiding this comment.
wow that's so much clearer! great approach!
There was a problem hiding this comment.
Thanks! Just had to write something my grug brain could understand haha
|
Can you rename to a clearer title and give a quick description? Also there's one piece of functionality that seems to have unintentionally changed: When you close a polyline by clicking on a point that already exists, the line tool should reset to its initial state of having nothing in the stack. As written, the last point stays selected |
av8ta
changed the title
|
Thanks for spotting that bug @MattFerraro - I thought I had wrapped my head around the old code well enough to make it simpler but clearly not! Fixed by clearing the stack when it's a point we've seen before a67b516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the ui state code when using the modeling tools confusing. Rather than a bunch of nested ifs and else ifs it's simpler implemented as a stack.