Update ToolBar.svelte #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Solve and Step from Sketch Actions
av8ta
suggested changes
Jun 2, 2024
Comment on lines
8
to
9
| let solving = false | ||
| // todo ask Matt why is this a no-op? |
There was a problem hiding this comment.
Some more things you could remove here
There was a problem hiding this comment.
And further down in the file too.
There was a problem hiding this comment.
@av8ta plz review I have made few more changes.
updated as per comment @av8ta
Remove Solve conditions
|
Sorry @bhiwagade-rahul I'm just going to go ahead and close this because it's more work teaching you what to do than it would be to just make the change. Hope you understand, we're a small team so we don't have time for this. |
|
@av8ta Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Solve and Step from Sketch Actions