A bit of housekeeping #65
Merged
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosly based on code in unit tests, which makes more sense as an example.
These might be created around in the repo by tests/examples and should probably not be added to git.
|
love this, thank you! Just wanted to say: a lot of work is going on in the |
|
Ill continue abit on storting out tests and examples after the merge with dev then. I think that has the potential to make it easier for new devs (including myself) to understand how the code works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few smaller things that i thought would be useful that also is abit of testing the water for what people think are good to try to improve.
A few things added to gitignore to get less junk in the status.
Introduce the concept of rust examples, which i think is very useful to run small commandline applications that can produce simple outputs, perhaps depending on inputs in the future. I think it makes more sense to use examples for such things that unit/integration tests (which i think should be validated in asserts, not by what output they produce if that makes sense)
Added abit of unit test on workbench.rs since it didnt have any. I think unit tests in the project probably could benefit from trying to test what actually that file does, not what is done in other files (make add some integration tests for this?)