Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of housekeeping #65

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

oyvindnetland
Copy link
Contributor

A few smaller things that i thought would be useful that also is abit of testing the water for what people think are good to try to improve.

A few things added to gitignore to get less junk in the status.

Introduce the concept of rust examples, which i think is very useful to run small commandline applications that can produce simple outputs, perhaps depending on inputs in the future. I think it makes more sense to use examples for such things that unit/integration tests (which i think should be validated in asserts, not by what output they produce if that makes sense)

Added abit of unit test on workbench.rs since it didnt have any. I think unit tests in the project probably could benefit from trying to test what actually that file does, not what is done in other files (make add some integration tests for this?)

Loosly based on code in unit tests, which makes more sense as
an example.
These might be created around in the repo by tests/examples
and should probably not be added to git.
@MattFerraro
Copy link
Collaborator

love this, thank you!

Just wanted to say: a lot of work is going on in the dev branch right now, including a fairly large refactor of almost all of the rust code. I expect we can get it landed in just a few days but please don't spend too much time fixing things on main as it is right now--I don't want any of your work or time to be wasted! These changes shouldn't conflict so I'm going to ahead and merge.

@MattFerraro MattFerraro merged commit ed67c2d into CADmium-Co:main May 30, 2024
2 checks passed
@oyvindnetland
Copy link
Contributor Author

Ill continue abit on storting out tests and examples after the merge with dev then. I think that has the potential to make it easier for new devs (including myself) to understand how the code works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants