patch linestring_to_wire to re-use actual vertex #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So truck's behavior here is a little weird. For a wire to be closed, it requires that the start vertex and end vertex of a wire are exactly the same. It isn't sufficient for them to contain identical data, they must refer to the same piece of memory.
As implemented, a linestring describing a square creates 5 vertices, where the last and first are identical but not the same piece of memory. The fix here is to re-use the first vertex when creating the final edge.