Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch linestring_to_wire to re-use actual vertex #56

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

MattFerraro
Copy link
Collaborator

So truck's behavior here is a little weird. For a wire to be closed, it requires that the start vertex and end vertex of a wire are exactly the same. It isn't sufficient for them to contain identical data, they must refer to the same piece of memory.

As implemented, a linestring describing a square creates 5 vertices, where the last and first are identical but not the same piece of memory. The fix here is to re-use the first vertex when creating the final edge.

@MattFerraro
Copy link
Collaborator Author

MattFerraro commented May 30, 2024

The failing third test is that we can no longer read and generate extrusions from project files which were generated before the great refactoring that replaced the old Sketch struct with the new ISOtope Sketch.

I can easily remake those project files once the UI is up and running again but for now I'd say let's just comment out the test and agree to revisit it again later

@av8ta
Copy link
Collaborator

av8ta commented May 30, 2024

I can easily remake those project files once the UI is up and running again but for now I'd say let's just comment out the test and agree to revisit it again later

@MattFerraro You can do this too: #[ignore = "test failing on CI"] and then we can go ahead and merge?

image

edit: don't worry I see you've already commented it out

@MattFerraro MattFerraro merged commit 04499d4 into dev Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants