Update to go122 165 #166
Merged
Update to go122 165 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
===========================================
- Coverage 71.36% 21.04% -50.33%
===========================================
Files 40 58 +18
Lines 4700 18940 +14240
===========================================
+ Hits 3354 3985 +631
- Misses 1066 14521 +13455
- Partials 280 434 +154 ☔ View full report in Codecov by Sentry. |
funkyshu
commented
Feb 19, 2024
| @@ -625,7 +625,7 @@ func generatePrivateKey(passphrase []byte) ([]byte, error) { | |||
| } | |||
|
|
|||
| if len(passphrase) > 0 { | |||
| pemBlock, err = x509.EncryptPEMBlock(rand.Reader, pemBlock.Type, pemBlock.Bytes, passphrase, x509.PEMCipherAES256) | |||
| pemBlock, err = ssh.MarshalPrivateKeyWithPassphrase(privateKey, "", passphrase) | |||
There was a problem hiding this comment.
This changed because x509.EncryptPEMBlock( is deprecated which the linter caught. It hard matters since it was in a test but for completeness, I updated it.
dustin-schnee
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Go1.22.
Update CI matrix to include 1.21 and 1.22.
Update GH action workflows to latest version.
Update golang-ci versions to 1.21.
Update go.mod to 1.21.
Update all dependencies.