Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkjavascript error fix #12

Merged
merged 3 commits into from
May 24, 2024
Merged

checkjavascript error fix #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b939a1
Apply automatic changes
memerchik May 24, 2024
dec870d
checkjavascript fix
memerchik May 24, 2024
b1dc168
Merge branch 'yaroslav-dev' of https://github.com/C2DH/journal-of-dig…
memerchik May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions checks/checkjavascript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ def checkplotlyconfig(outputs_value):

for j in range(0, len(outputs_value), 1):
checks_limit = 10
if (
"data" not in outputs_value[j]
or "text/html" not in outputs_value[j]["data"]
):
continue

m = "text/html" in outputs_value[j]["data"]

if m == False:
Expand Down
20 changes: 15 additions & 5 deletions report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Report for example/article_example_checkoutput.ipynb ❤

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

## Cell Counts
**all cells: 115 **
**all cells: 115**
code_empty: 0
markdown: 88
code: 27
Expand Down Expand Up @@ -34,6 +36,8 @@ Programming language is **R (4.2.3)**
Total output size: 3280.85 KB
Total number of images: 10
Total number of tables: 1
Total number of audios: 1

> [!WARNING]
> Notebook's output contains **text/plain** which is deprecated.

Expand All @@ -42,6 +46,7 @@ Total number of tables: 1
| text/html | True |
| text/plain | True |
| image/png | True |
| audio | False |

| Output type | Presence |
| --- | --- |
Expand Down Expand Up @@ -192,14 +197,19 @@ Total number of tables: 1

### Check URLs

**Invalid URLs (404 - 1):**

Invalid URL (404): https://licensebuttons.net/l/by/4.0/88x31.png)](https://creativecommons.org/licenses/by/4.0/
**Impossible to verify (non-404 error code - 1):**

Invalid URL (Other - 301): http://www.museogalileo.it/esplora/biblioteche/biblioteca/archivionomi.html

> [!TIP]
> Even if some of the urls listed above don't seem to be broken, try to replace them with the valid ones as they might become unavailable soon.

**Valid URLs (200 - 1):**

Valid URL (200): https://creativecommons.org/licenses/by/4.0/
**Valid URLs (200 - 2):**

1. https://licensebuttons.net/l/by/4.0/88x31.png
2. https://creativecommons.org/licenses/by/4.0/


### Check JavaScript
Expand Down
Loading