Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History #9

Merged
merged 6 commits into from
May 2, 2020
Merged

History #9

merged 6 commits into from
May 2, 2020

Conversation

C-Sto
Copy link
Owner

@C-Sto C-Sto commented Apr 16, 2020

Add History option

@C-Sto
Copy link
Owner Author

C-Sto commented May 2, 2020

This should close #8 once it's merged. Only thing left to do is performance checks.

@C-Sto
Copy link
Owner Author

C-Sto commented May 2, 2020

Master:

❯ go test -bench . -benchtime 100x
goos: darwin
goarch: amd64
pkg: github.com/C-Sto/gosecretsdump/test/bench
BenchmarkProgram-8           100         197760348 ns/op        222588018 B/op    234725 allocs/op
PASS
ok      github.com/C-Sto/gosecretsdump/test/bench       20.307s

history:

❯ go test -bench . -benchtime 100x
goos: darwin
goarch: amd64
pkg: github.com/C-Sto/gosecretsdump/test/bench
BenchmarkProgram-8           100         196002770 ns/op        222695305 B/op    234894 allocs/op
PASS
ok      github.com/C-Sto/gosecretsdump/test/bench       19.836s

Not sure how it has better performance, presumably the test machine has other stuff going on.

@C-Sto C-Sto merged commit 091b4e6 into master May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant