This repository has been archived by the owner on May 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
Revise german translation #562
Open
trkoch
wants to merge
4
commits into
BustByte:master
Choose a base branch
from
trkoch:revise-de-translation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trkoch
force-pushed
the
revise-de-translation
branch
from
April 10, 2020 13:58
ab13e2d
to
f8ceb93
Compare
Great work! Could you add a config as well? It should be in the |
Ups never mind! I see it's already added, sorry about that |
@michaelmcmillan Yes. Translations, including config, were already added in #528. |
trkoch
force-pushed
the
revise-de-translation
branch
from
April 10, 2020 19:29
f8ceb93
to
0672652
Compare
Proof reading revealed some clumsy translations. * Change gender to common options (divers is the 3rd gender by law) * Use or do not translate common loanwords such as tool * Fix grammar by adjusting to context * Minor typos The translation for "Using self-report, you can get (...)" was pretty tough, but I hope I did not deviate from its original meaning too much.
Unfortunately coronastatus.de is already taken. As a bonus, the pattern {country}.coronastatus.eu gives us a fall-back for all european countries where the domain is not available.
trkoch
force-pushed
the
revise-de-translation
branch
from
April 10, 2020 19:44
f9138b4
to
e8f7c8f
Compare
Some finishing touches and last minute change of domain. Anything missing? |
floste7
reviewed
Apr 26, 2020
@@ -53,7 +53,7 @@ | |||
"Have you been tested for COVID-19?": "Wurdest du auf COVID-19 getestet?", | |||
"Headache": "Kopfschmerzen", | |||
"Healthy": "Gesund", | |||
"Help us uncover and predict the corona spread in your area": "Hilf uns die Corona Verbreitung in deiner Gegend <span>aufzudecken</span> und <span>vorauszusagen</span>", | |||
"Help us uncover and predict the corona spread in your area": "Hilf uns die Verbreitung von Corona in deiner Gegend <span>aufzudecken</span> und <span>vorauszusagen</span>", | |||
"here": "hier", | |||
"How will my data be used?": "Wir werden meine Daten verwendet?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to be "Wie werden meine Daten verwendet?"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof reading revealed some clumsy translations.
The translation for "Using self-report, you can get (...)" was pretty tough,
but I hope I did not deviate from its original meaning too much.