Repository navigation
fix(android): letterbox portrait video correctly in the player view - #64
Open
TenGosc007 wants to merge 2 commits into
Open
TenGosc007 wants to merge 2 commits into
TenGosc007 wants to merge 2 commits into
Conversation
…rectly Media3's AspectRatioFrameLayout letterboxes the video surface in response to onVideoSizeChanged via requestLayout, which is swallowed by the RN view hierarchy — the inner surface view is never re-measured and keeps its initial full-box bounds, stretching portrait video to full width. Force the measure/layout pass manually so the SDK's resize_mode="fit" applies (video and controls keep proper bounds inside the full-size player view). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
controlsSection centers children, shrinking the speed rows to content width and collapsing the flex buttons into thin strips. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
jakubboguski
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Portrait video was stretched to the full player width on Android.
Media3's
AspectRatioFrameLayoutletterboxes the surface viarequestLayout(), which the RN view hierarchy swallows — the surfaceview was never re-measured. The wrapper now forces the measure/layout
pass on
onVideoSizeChanged, so the SDK'sresize_mode="fit"applies(video pillarboxed, controls full-width). Also fixes the example app's
speed buttons collapsing under custom controls.
Type of Change
Affected Areas
Testing
yarn typecheckyarn lintyarn androidinexample/)Android emulator renders pillarboxed; native + custom controls OK
Library User Impact
Bug fix only — portrait VOD now letterboxes like iOS; no API changes.
AI Assistance
Checklist