Repository navigation
feat(example): secret-free release builds, auto-play toggle, and upload lifecycle fixes - #51
Open
TenGosc007 wants to merge 8 commits into
Open
TenGosc007 wants to merge 8 commits into
TenGosc007 wants to merge 8 commits into
Conversation
TenGosc007
added this pull request to stack #44
October 8, 2026 06:27
TenGosc007
force-pushed
the
fix/ios-video-upload
branch
from
October 9, 2026 10:06
edc8d93 to
aa4bca4
Compare
startUpload creates the video entry before the transfer begins, so cancelling only aborted the transfer and left a "processing" orphan in the library. Both bridges now track videos they created themselves and delete them on cancel; continueUpload videos belong to the caller and are never touched. iOS also normalizes tracker-derived videoIds to lowercase — UUID.uuidString uppercases the GUID, which made the case-sensitive management API return 404 on delete. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…stener Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
TenGosc007
force-pushed
the
fix/ios-video-upload
branch
from
October 10, 2026 18:53
aa4bca4 to
5c36ef3
Compare
On Android the ownership marker outlived a completed upload, so a later cancelUpload deleted the fully uploaded video — iOS already drops the marker on .uploaded/.removed. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
jakubboguski
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles the iOS upload fixes and example-app work:
Playback
until the setting loads (fixes the AsyncStorage race where autoPlay=false
arrived after playback already started). Live player gets a Play overlay —
the native live host exposes no pause command.
Upload — iOS bridge
RCTEventEmitter/RCTCallableJSModules;they were silently dropped in bridgeless mode (
RCTBridge.current()isnil), which caused stuck 0% progress and
Unknown uploadIdon re-cancel.restoreUploadsmoved off the JS thread (froze the app);requiresMainQueueSetup = NO.cancelUploaddeletes the server-side video entry the upload created —startUploadpre-provisions a videoId, so cancelled uploads left"processing" orphans.
continueUploadvideos belong to the caller andare never deleted.
UUID.uuidStringuppercases GUIDs; Bunny's management API iscase-sensitive and returned 404 on delete — normalized to lowercase.
Upload — example app
a confirmed Delete, and upload rows/state now persist across screen
unmounts (module-level stores + richer
pausedevent payload).Verified: iOS
xcodebuild, AndroidcompileDebugKotlin,yarn typecheck,yarn lint, upload jest suite.