Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXUP] passing wrong object for transforming refs #1546

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

newbie95
Copy link
Contributor

@newbie95 newbie95 commented Sep 4, 2024

Added fixup for the issue

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: e545b73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Sep 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e545b73. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@samijaber
Copy link
Contributor

please create pull requests using our pull request template. it includes instructions and steps that you need to follow for your PR to be mergable to the repo.

https://github.com/BuilderIO/mitosis/blob/main/.github/pull_request_template.md

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR request template not followed: missing changeset and tests

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! You can actually get rid of the new test: the existing snapshots cover your bugfix

packages/core/src/__tests__/test-generator.ts Outdated Show resolved Hide resolved
@samijaber samijaber merged commit d13e693 into BuilderIO:main Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants