DRAFT: 1333 slots with data #1336
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(1333): Fixed whitespace issues in svelte snapshot
feat(1333): made vue, react, and svelte slots consistent
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft PR for #1333
Added support for data binding on slots
I want to use mitosis but I'm using slots in a
<For ..component so I need to pass the itemI'm currently concerned about the react implementation.
When props are required it looks like
(exampleProps) => <Component {...exampleProps} />However, when no props it currently looks like
() => <Component />which causes backwards compatibility issues.This may be solved by not doing the latter, however, that is inconsistent so might also not be ideal.