Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove use of soon to be deprecated method #1298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove use of soon to be deprecated method #1298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"@builder.io/react": "^1.1.50",
"astring": "^1.8.3",
"csstype": "^3.0.4",
"estree-walker": "^3.0.3",
"fp-ts": "^2.11.10",
"hash-sum": "^2.0.0",
"json5": "^2.1.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/parsers/svelte/html/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { walk } from 'svelte/compiler';
import { walk } from 'estree-walker';
import type { MitosisNode } from '../../../types/mitosis-node';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be some breaking changes between the svelte/compiler.walk types we have and the latest estree-walker. The codebase is on svelte 3.53.1...I'm not sure what the changes are 🤔


import { parseEach } from './each';
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/parsers/svelte/instance/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { isAssignmentExpression, isIdentifier, isUpdateExpression } from '@babel
import { generate } from 'astring';
import type { CallExpression, FunctionDeclaration, Identifier } from 'estree';
import { capitalize } from 'lodash';
import { walk } from 'svelte/compiler';
import { walk } from 'estree-walker';
import { stripQuotes } from '../helpers/string';

import type { SveltosisComponent } from '../types';
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/parsers/svelte/instance/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { generate } from 'astring';
import { walk } from 'svelte/compiler';
import { walk } from 'estree-walker';

import { parseGetContext, parseHasContext, parseSetContext } from './context';
import { parseMemberExpression } from './expressions';
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/parsers/svelte/module/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { generate } from 'astring';
import { walk } from 'svelte/compiler';
import { walk } from 'estree-walker';

import type { BaseNode, ExportNamedDeclaration, Identifier, VariableDeclaration } from 'estree';
import type { Ast } from 'svelte/types/compiler/interfaces';
Expand Down
1 change: 1 addition & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,6 +2351,7 @@ __metadata:
astring: ^1.8.3
concurrently: ^8.2.2
csstype: ^3.0.4
estree-walker: ^3.0.3
fp-ts: ^2.11.10
fs-extra-promise: ^1.0.1
hash-sum: ^2.0.0
Expand Down
Loading