Skip to content

Conversation

midhunadarvin
Copy link
Contributor

@midhunadarvin midhunadarvin commented Oct 1, 2025

Description

  • expose contentId on the builder class
  • update the trackConversion method to figure out contentId and variantionId if they are undefined from the SDK value and cookies.

Loom
https://www.loom.com/share/3712e28c436b4d9eac9bd3e6a2a68325


Note

Exposes contentId on the SDK and updates conversion tracking to auto-resolve contentId/variationId (from state/cookies), with React setting contentId during inline renders.

  • Core SDK (packages/core):
    • Expose contentId on Builder via contentId$ with get/set accessors.
    • Update trackConversion to:
      • Use stored contentId when not provided.
      • Derive variationId from test cookies when absent.
      • Only include variationId if it differs from contentId.
  • React (packages/react):
    • When rendering inline with initialContent, set builder.contentId before tracking impression.

Written by Cursor Bugbot for commit 2b3c663. This will update automatically on new commits. Configure here.

@midhunadarvin midhunadarvin self-assigned this Oct 1, 2025
Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: 2b3c663

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/react Patch
@builder.io/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cursor[bot]

This comment was marked as outdated.

Copy link

nx-cloud bot commented Oct 1, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 2b3c663

Command Status Duration Result
nx test @snippet/angular-17-ssr ❌ Failed 6m 51s View ↗
nx test @snippet/angular-17 ❌ Failed 6m 36s View ↗
nx test @snippet/react ❌ Failed 3m 28s View ↗
nx test @snippet/vue ❌ Failed 3m 8s View ↗
nx test @snippet/svelte ❌ Failed 3m View ↗
nx test @e2e/qwik-city ✅ Succeeded 11m 18s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 9m 40s View ↗
nx test @e2e/nuxt ✅ Succeeded 9m 28s View ↗
Additional runs (37) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-10-01 08:57:59 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant