-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Chore/bump isolated vm #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Chore/bump isolated vm #4145
Conversation
🦋 Changeset detectedLatest commit: 4356787 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Battjmo does the install work on your machine? It seems to now break in CI for v6.x If yes, what node version are you using? |
Yep, build worked in the react package, Node v24.4.1 or v22.12.0 v6 of what? I'm getting version 8.2.6 in the build output for the SDK version. |
bumping isolated-vm to v6.0.0 fails in our CI, see https://github.com/BuilderIO/builder/actions/runs/17800387929/job/50623875294?pr=4145#step:4:584 I think it's because our CI is using node v18 builder/.github/workflows/ci.yml Lines 29 to 33 in f5a63e7
whereas isolated-vm v6 expects node >=22 https://github.com/laverdet/isolated-vm/blob/5dc622865679323a6b68dca7762e49d82d7f67ff/package.json#L7-L9 so i think this PR needs to also bump the node version across the board (all github Line 1 in f5a63e7
|
Makes sense, about time we get this thing off of 18 anyway. I'll get cracking on it. |
thanks for the PR @Battjmo! 🚀 |
Alright, I went ahead and disregarded my previous statement about not updating everything and just updated everything. Come ooooooon ci. |
View your CI Pipeline Execution ↗ for commit 4356787
☁️ Nx Cloud last updated this comment at |
All of the tests in |
Alright, I'm a little confused by the output here. It looks like I passed CI but maybe also not? @samijaber ? |
Description
#4137
Bump
isolated-vm
to version 6.x.x, which supports Node 24: https://github.com/laverdet/isolated-vm?tab=readme-ov-file. I took a look through the commits on that release and didn't see anything that looked like it would impact functionality. The tests in the React package seem to all be borked on main so I can't confirm, took a stab at updating the contributing docs in there too to useyarn
instead ofnpm
.I only did it in the React package since I don't want to get too far into the weeds and that's the one I use on my project.