Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ABI lib #388

Closed

Conversation

trinhdn2
Copy link
Contributor

@trinhdn2 trinhdn2 commented Oct 8, 2023

Resolve issue #387
Require PR #385 to be merged first

This PR fixes a few issues:

  • If there is no return in a call function, unpack should return nil error
  • For some functions which have struct array as parameter, it will also be detected and generate the struct definition
  • For the event, if it has a non-indexed parameter, the parameter name will also be assigned if empty. Also the internal struct will be detected and generate struct definition if not exist.
  • Fix annotation generation in the event function

Besides, this PR uses internalType information to generate struct binding. The internalType is introduced in solidity v0.5.11 which represents the raw name of struct.

@tungng98 tungng98 deleted the branch BuildOnViction:upgrade-core-develop December 10, 2023 16:51
@tungng98 tungng98 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants