Skip to content

Conversation

@chillenb
Copy link
Contributor

@chillenb chillenb commented Jun 5, 2025

Added #include <cstdint> to builder_context.h to fix the following compile error:

CXX    annotate.o
In file included from /home/chillenb/src/buildit/include/builder/builder_base.h:8,
                 from /home/chillenb/src/buildit/include/builder/builder.h:3,
                 from /home/chillenb/src/buildit/src/builder/annotate.cpp:1:
/home/chillenb/src/buildit/include/builder/builder_context.h:25:9: error: ‘uint32_t’ does not name a type
   25 |         uint32_t size;
      |         ^~~~~~~~
/home/chillenb/src/buildit/include/builder/builder_context.h:11:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include <cstdint>’
   10 | #include <unordered_set>
  +++ |+#include <cstdint>
   11 | #include <vector>

@AjayBrahmakshatriya
Copy link
Collaborator

Hey @chillenb thanks a lot for the changes. I am guessing cstdint was included indirectly through some standard library on my system/gcc installation.

Howevery, one of the checks failed for your PR because github has discontinued support for Ubuntu 20.04 runners. I have updated the CI scripts. Could you pull the changes from master and update the PR?

Thanks!

@AjayBrahmakshatriya AjayBrahmakshatriya self-assigned this Jun 6, 2025
@AjayBrahmakshatriya AjayBrahmakshatriya added the bug Something isn't working label Jun 6, 2025
@chillenb
Copy link
Contributor Author

chillenb commented Jun 7, 2025

Sure, I just rebased and it should work now!

@AjayBrahmakshatriya
Copy link
Collaborator

Looks good to me! Thanks for the contribution!

@AjayBrahmakshatriya AjayBrahmakshatriya merged commit a023d2a into BuildIt-lang:master Jun 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants