Added compartment attribute to Component under set_species. #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added compartment attribute to Component under set_species.
Made lines shorter
Addition of 2 components and 2 mechanism for Membrane Proteins
|
Hi @zjuradoq this code looks great - could you please add a simple unit test (probably in test_components.py) just to make sure we don't break your fix in the future? Happy to walk you through that if you are unsure of how to proceed. |
Dev master to Dev local
Tests for compartments in components
|
@WilliamIX test_component.py has be updated and pushed to test comparment addition to component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compartment attribute to Component under set_species. Sorry for all pull-request notification.
Addresses Issue #256