Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language support to makefile #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tdy
Copy link

@tdy tdy commented Feb 26, 2021

Following up on #151, this PR enables users to set the language via make rather than manually editing the script, e.g.,

$ make LANGUAGE="en_US" install

Edit: I just noticed the contrib guidelines about basing new features on develop. I don't know if that applies to a small patch like this. I can rebase on develop if preferred.

@Genghius
Copy link
Contributor

ehhhh....
this is....
yesn't...
like.....
bruh.

do people hate editing a single line that much?

@tdy
Copy link
Author

tdy commented Feb 27, 2021

do people hate editing a single line that much?

This is mainly to support packaging workflows, like arch's AUR.

@BeyondMagic
Copy link
Contributor

Edit: I just noticed the contrib guidelines about basing new features on develop. I don't know if that applies to a small patch like this. I can rebase on develop if preferred.

nah, it's preferably here. develop is not being developed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants