Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straight conversion of screenshot code from mutter to wayland #669

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fossfreedom
Copy link
Contributor

@fossfreedom fossfreedom commented Jan 26, 2025

Description

The budgie-wm elements have been moved to the power dialog - i.e. keeping the separate of daemon windows vs screencapture which cannot work in the same process.

Note - introduces grim for the screencapture part

ActiveWindow screencapture is now not possible without a compositor that exposes where on that screen the window is located. i.e. labwc doesn't, whereas sway and hyprland does. So added a method to support those compositors (that we recognise) that have that support. Code will need to be added to find the window location for those compositors.

Multi-monitor support is not there at the moment. Might have to drop the existing "SelectLayer" code which displays the area to capture and replace with slurp

Marking as draft for the moment

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

fossfreedom and others added 6 commits January 26, 2025 12:16
The budgie-wm elements have been moved to the power dialog - i.e.
keeping the separate of daemon windows vs screencapture which
cannot work in the same process.
* icon-tasklist: Remove last references to xid

Signed-off-by: Evan Maddock <[email protected]>

* icon-tasklist: Remove always-on-top button because there is no standard way to do that

Signed-off-by: Evan Maddock <[email protected]>

---------

Signed-off-by: Evan Maddock <[email protected]>
The budgie-wm elements have been moved to the power dialog - i.e.
keeping the separate of daemon windows vs screencapture which
cannot work in the same process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants