-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bridge between gsettings and labwc #643
Conversation
So if a media key has not been specifically defined the bridge should grab the -static key equivalent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Will need to test it out after some of the changes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fossfreedom While testing it, I had an import error on the systemd module. I suspect we should check that python3-systemd is installed alongside any other python3 modules that aren't part of the python3 base install. Will install them on my system to test further.
Jan 11 12:21:51 minion org.buddiesofbudgie.labwc-bridge.desktop[15756]: Traceback (most recent call last):
Jan 11 12:21:51 minion org.buddiesofbudgie.labwc-bridge.desktop[15756]: File "/usr/libexec/budgie-desktop/labwc_bridge.py", line 16, in <module>
Jan 11 12:21:51 minion org.buddiesofbudgie.labwc-bridge.desktop[15756]: from systemd.journal import JournalHandler
Jan 11 12:21:51 minion org.buddiesofbudgie.labwc-bridge.desktop[15756]: ModuleNotFoundError: No module named 'systemd'
Interestingly I already had python3-systemd installed. What python modules did you need for this to work? |
Exactly that. Under debian it's the python3-systemd module. I would have thought that was common across all distros to be able to write warning type statements to journald |
Yea I checked the instructions at https://github.com/systemd/python-systemd/blob/main/README.md and indeed it should be python3-systemd. |
Figured out the issue was python3 was being loaded from homebrew. Now that I got it running, I get the following:
|
Confirmed with Josh that this was a distro specific key - better here to be more robust to confirm keys actually exist in the schema before further processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validated and LGTM 🥳
Description
This PR provides a bridge between gsettings changes and the labwc equivalents.
labwc config files are environment and rc.xml located in your home folder.
The bridge listens to various gsettings schemas, looks to see if there is an equivalent labwc setting and changes that in the configuration files. A call to labwc -r is used to reload the configuration file to apply the changes.
This is a one-way bridge - gsettings are applied to labwc - manual changes to those config files are not reflected back to gsettings.
On first login, the home folder configuration files are copied from budgie templates held in /usr/share/budgie-desktop.
Note - for distros, those templates can be prefixed with "distro-" located in the same shared folder and this is used in instead of the default template - i.e. allows distros to tailor what labwc configuration results.
The nominal supported gsettings supported are too numerous to list here - the areas covered in the bridge are
Submitter Checklist
git rebase -i
(if needed)