Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker CLI doc has a wrong argument order #7

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

yheuhtozr
Copy link
Contributor

After reading Bubka/2FAuth#287 (comment):

DOES NOT WORK

pi@pi5:~ $ sudo docker run -it --rm -p 8000:8000/tcp
-v /home/pi/2fauth:/2fauth 2fauth/2fauth
-e AUTHENTICATION_GUARD=web-guard
-e APP_URL=http://localhost:8000/
-e ASSET_URL=http://localhost:8000/

WORKS

pi@pi5:~ $ sudo docker run -it --rm -p 8000:8000/tcp
-e AUTHENTICATION_GUARD=web-guard
-e APP_URL=http://localhost:8000/
-e ASSET_URL=http://localhost:8000/
-v /home/pi/2fauth:/2fauth 2fauth/2fauth

I went to check the official Docker reference:

docker container run [OPTIONS] IMAGE [COMMAND] [ARG...]

so it turns out that 2fauth/2fauth chunk is not part of options and should come after all of options, or otherwise those which come after it are not passed as valid options.

@Bubka Bubka merged commit 1e7b893 into Bubka:main Jan 28, 2024
1 check failed
@Bubka
Copy link
Owner

Bubka commented Jan 28, 2024

Thanks for the PR, the Docs site is up-to-date 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants