Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling the chemdose_ph_chain examples from the vignettes,
![image](https://private-user-images.githubusercontent.com/8097919/384654739-bd027c0d-b0cf-4813-a40d-b7c2625dcf75.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5OTQ2MTIsIm5iZiI6MTczODk5NDMxMiwicGF0aCI6Ii84MDk3OTE5LzM4NDY1NDczOS1iZDAyN2MwZC1iMGNmLTQ4MTMtYTQwZC1iN2MyNjI1ZGNmNzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDhUMDU1ODMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzBlMmUyNmZjNTM0YWQ3ODg4YTI0ZDM3YTg3M2UyMzQ1N2MzMmZiZTc4Y2ExNjc3NGZkMTA2YzIxYTI3ZWEwNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.QZv9dI-VKEHsgH1jW9xuV1ndoKeC8uVWqo3ir2kqIow)
correct_k
was noticed to be slow:Applying optimizations contained within:
correct_k
goes from 1980ms to 90ms (-95.4% faster)Overall example goes from 7.74s to 5.67s (-27% faster).
These changes and gains are independent of: #7